Skip to content

fix(i18n): add-missing-norwegian-nb-NO-translations#2677

Merged
graphieros merged 4 commits intonpmx-dev:mainfrom
bonsak:Fix/add-missing-norwegian-nb-NO-translations
May 5, 2026
Merged

fix(i18n): add-missing-norwegian-nb-NO-translations#2677
graphieros merged 4 commits intonpmx-dev:mainfrom
bonsak:Fix/add-missing-norwegian-nb-NO-translations

Conversation

@bonsak
Copy link
Copy Markdown
Contributor

@bonsak bonsak commented May 5, 2026

🔗 Linked issue

🧭 Context

Some keys in 'en.json' where missing in nb-NO.json

Updated missing nb-NO translations.

📚 Description

Missing keys in nb-NO.json was added and translated to Norwegian.

First translation pass generated by Opus 4.5. Second pass proofread by me.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment May 5, 2026 6:21am
npmx.dev Ready Ready Preview, Comment May 5, 2026 6:21am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored May 5, 2026 6:21am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41067b7a-059f-4e48-8b58-a948399bce80

📥 Commits

Reviewing files that changed from the base of the PR and between b91bcee and 70eacf3.

📒 Files selected for processing (1)
  • i18n/locales/nb-NO.json
✅ Files skipped from review due to trivial changes (1)
  • i18n/locales/nb-NO.json

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Extended Norwegian translations across the app, adding and expanding strings for the footer, shortcuts, settings, package texts, timeline events, README error message, and leaderboard likes.
    • Added localized labels and tooltips for comparison UI (including scatter chart) and facet items such as stars, issues and creation date to improve Norwegian coverage.

Walkthrough

This PR updates the Norwegian (nb-NO) translation file by adding and extending multiple keys across footer, shortcuts, settings, package-related strings (size, replacement, links, timeline, likes), README, leaderboard, and compare UI translations.

Changes

Norwegian Localisation Extensions

Layer / File(s) Summary
Data / Keys Added
i18n/locales/nb-NO.json
Adds new translation keys: footer.resources, footer.features, footer.other, shortcuts.open_timeline, settings.sections.enable_code_ligatures, and common.per_week_short.
Package-level Strings
i18n/locales/nb-NO.json
Introduces package.size_decrease block; extends package.replacement with example and native_no_version; adds package.links.timeline.
Package Likes & Leaderboard
i18n/locales/nb-NO.json
Adds package.likes rank strings (top_rank_tooltip, top_rank_label, top_rank_link_label) and a new top-level leaderboard.likes block (title, description, rank/likes labels, unavailable state).
Timeline & README
i18n/locales/nb-NO.json
Adds package.timeline entries (load_more, load_error, multiple event labels for size/dep/license/ESM/types/trust/provenance) and readme.error_loading`.
Compare UI / Facets
i18n/locales/nb-NO.json
Adds compare.scatter_chart translations (axis labels, freshness, copy alt text, filename) and compare.facets.items labels/descriptions for githubStars, githubIssues, and createdAt.

Possibly related PRs

  • npmx-dev/npmx.dev#2293: Modifies the same i18n/locales/nb-NO.json with overlapping Norwegian translation additions.
  • npmx-dev/npmx.dev#2625: Adds similar i18n keys (footer, shortcuts, package timeline, README error) across locale files.
  • npmx-dev/npmx.dev#2607: Applies comparable i18n additions (shortcuts, settings, package links, compare facets) in other locales.

Suggested reviewers

  • ghostdevv
  • serhalp
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing Norwegian translations to the nb-NO.json file.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding missing Norwegian translations that were present in en.json.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/nb-NO.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/nb-NO.json`:
- Around line 24-26: The footer label values for the translation keys
"resources", "features", and "other" are in Title Case and should match the
surrounding lower-case style; update the string values for the keys resources,
features, and other in nb-NO.json to lower-case (e.g., "ressurser",
"funksjoner", "annet") so the menu casing is consistent.
- Line 1289: Update the translation value for the "analysis" key so it preserves
the intentional space before the colon: replace the current "{package}: {x_name}
({x_value}) og {y_name} ({y_value})" with "{package} : {x_name} ({x_value}) og
{y_name} ({y_value})" (the JSON key to locate is
compare.scatter_chart.copy_alt.analysis / the "analysis" property shown in the
diff).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f0180500-648d-4cdf-b452-dc2ac3758e3b

📥 Commits

Reviewing files that changed from the base of the PR and between 018097e and b91bcee.

📒 Files selected for processing (1)
  • i18n/locales/nb-NO.json

Comment thread i18n/locales/nb-NO.json
Comment thread i18n/locales/nb-NO.json Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🌿

@graphieros graphieros added this pull request to the merge queue May 5, 2026
Merged via the queue into npmx-dev:main with commit b8abae0 May 5, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants